Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: fix project image display in project page #10405

Merged
merged 1 commit into from
Jan 22, 2025
Merged

front: fix project image display in project page #10405

merged 1 commit into from
Jan 22, 2025

Conversation

RomainValls
Copy link
Contributor

close #10400

@RomainValls RomainValls self-assigned this Jan 16, 2025
@RomainValls RomainValls requested a review from a team as a code owner January 16, 2025 13:09
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Jan 16, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2025 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.78%. Comparing base (9151b80) to head (b415b13).
Report is 69 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev   #10405      +/-   ##
==========================================
+ Coverage   81.62%   81.78%   +0.15%     
==========================================
  Files        1067     1073       +6     
  Lines      105624   106578     +954     
  Branches      727      731       +4     
==========================================
+ Hits        86216    87161     +945     
- Misses      19367    19378      +11     
+ Partials       41       39       -2
Flag Coverage Δ
editoast 74.21% <ø> (+0.53%) ⬆️
front 89.34% <ø> (+0.02%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

emersion
emersion approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I can't reproduce on my machine… The image displays correctly in both cases.

That said, I can't see why we were using absolute positioning here.

@RomainValls RomainValls force-pushed the rvs/front-fix-project-image-display branch from 2ff8b7a to b415b13 Compare January 22, 2025 10:39
@RomainValls RomainValls added this pull request to the merge queue Jan 22, 2025
Merged via the queue into dev with commit 4e2a676 Jan 22, 2025
27 checks passed
@RomainValls RomainValls deleted the rvs/front-fix-project-image-display branch January 22, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emersion emersion emersion approved these changes

@achrafmohye achrafmohye Awaiting requested review from achrafmohye

Assignees

@RomainValls RomainValls

Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Project image not displayed on firefox
3 participants
@RomainValls @codecov-commenter @emersion